Skip to content

Remove unnecessary sleep from test#3600

Merged
RPRX merged 1 commit intoXTLS:mainfrom
mmmray:test-sleep
Jul 27, 2024
Merged

Remove unnecessary sleep from test#3600
RPRX merged 1 commit intoXTLS:mainfrom
mmmray:test-sleep

Conversation

@mmmray
Copy link
Contributor

@mmmray mmmray commented Jul 26, 2024

These were copypasted to splithttp tests and then removed there

I can't imagine what they were supposed to do, the tests run fine without

These were copypasted to splithttp tests and then removed there

I can't imagine what they were supposed to do, the tests run fine
without
@Fangliding
Copy link
Member

It appears to be a legacy part, where wstest used gofunc and returned a failure after 5 seconds(timeout)
Later, this mechanism was removed, but this line of code was retained, so it looks confusing

@RPRX RPRX merged commit 7cf5ee8 into XTLS:main Jul 27, 2024
@mmmray mmmray deleted the test-sleep branch July 27, 2024 14:20
leninalive pushed a commit to amnezia-vpn/amnezia-xray-core that referenced this pull request Oct 29, 2024
it2konst pushed a commit to it2konst/gametunnel-core that referenced this pull request Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants